On Fri, 31 Oct 2025 08:37:09 +0300
Dan Carpenter <[email protected]> wrote:
> 4271 if ((tr->text_delta)) {
> 4272 /* ftrace and system call events are still
> OK */
> --> 4273 if ((event->type > __TRACE_LAST_TYPE) &&
> 4274 !is_syscall_event(event))
>
> I feel like there was a line of code here that was accidentally left out
> of the commit.
Or one was added ;-)
>
> 4275 return print_event_fields(iter, event);
>
> Or we could add another tab here, but my guess is there is a missing
> statement.
The commit that caused this had:
@@ -4251,10 +4268,12 @@ static enum print_line_t print_trace_fmt(struct
trace_iterator *iter)
* safe to use if the array has delta offsets
* Force printing via the fields.
*/
- if ((tr->text_delta) &&
- event->type > __TRACE_LAST_TYPE)
+ if ((tr->text_delta)) {
+ /* ftrace and system call events are still OK */
+ if ((event->type > __TRACE_LAST_TYPE) &&
+ !is_syscall_event(event))
return print_event_fields(iter, event);
-
+ }
return event->funcs->trace(iter, sym_flags, event);
}
I broke the original if statement into two if statements so that it would
look better when I added another conditional. I just forgot to increase the
indentation of the if block.
Thus, a new tab is needed.
Thanks,
-- Steve
