Just use a guard and also move the path_put() out of the credential change's scope. There's no need to do this with the overridden credentials.
Signed-off-by: Christian Brauner <[email protected]> --- drivers/crypto/ccp/sev-dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 0d13d47c164b..c5e22af04abb 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -259,8 +259,8 @@ static int sev_cmd_buffer_len(int cmd) static struct file *open_file_as_root(const char *filename, int flags, umode_t mode) { + struct path root __free(path_put) = {}; struct file *fp; - struct path root; struct cred *cred; const struct cred *old_cred; @@ -275,7 +275,6 @@ static struct file *open_file_as_root(const char *filename, int flags, umode_t m old_cred = override_creds(cred); fp = file_open_root(&root, filename, flags, mode); - path_put(&root); put_cred(revert_creds(old_cred)); -- 2.47.3
