On 11/19/2025 11:46 PM, Lorenzo Stoakes wrote:
> On Wed, Nov 19, 2025 at 03:55:29PM +0530, Garg, Shivank wrote:
>>>
>>> With comments below addressed, LGTM so:
>>>
>>> Reviewed-by: Lorenzo Stoakes <[email protected]>
>>
>> Thank you for the review.
>>
>> Looking at the code, the dirty/writeback checks where I'm making changes
>> are all in the !is_shmem branch, so it only affects regular files, not
>> shmem.
>
> Yeah sorry I think I was being somehow blind to the fact that each
> dirty/writeback test has !is_shmem, esp. given I literally quote it there :)
>
> So err ignore me I think here haha
>
>>
>> Should I mention in the commit message that these changes are limited
>> to regular files and don't affect shmem?
>
> No that's fine.
>
>>
>> I'm not sure I fully understood your concern on shmem. Could you please
>> elaborate?
>
> Yeah I think I just misread the code after a long day :P
>
>>
Thanks for clarifying!
I held off adding your Reviewed-by tag to v2 since there were some more changes
from v1. Let me know if you're still happy with it and I can add it for v3.
Best Regards,
Shivank
