On Thu, 20 Nov 2025 15:56:03 -0500 Steven Rostedt <[email protected]> wrote:
> From: Steven Rostedt <[email protected]> > > The function trigger_process_regex() is called by a few functions, where > only one calls strim() on the buffer passed to it. That leaves the other > functions not trimming the end of the buffer passed in and making it a > little inconsistent. > > Remove the strim() from event_trigger_regex_write() and have > trigger_process_regex() use strim() instead of skip_spaces(). The buff > variable is not passed in as const, so it can be modified. > Looks good to me. Acked-by: Masami Hiramatsu (Google) <[email protected]> Thanks, > Signed-off-by: Steven Rostedt (Google) <[email protected]> > --- > kernel/trace/trace_events_trigger.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/kernel/trace/trace_events_trigger.c > b/kernel/trace/trace_events_trigger.c > index 16e3449f3cfe..1dfe69146a81 100644 > --- a/kernel/trace/trace_events_trigger.c > +++ b/kernel/trace/trace_events_trigger.c > @@ -309,7 +309,8 @@ int trigger_process_regex(struct trace_event_file *file, > char *buff) > char *command, *next; > struct event_command *p; > > - next = buff = skip_spaces(buff); > + next = buff = strim(buff); > + > command = strsep(&next, ": \t"); > if (next) { > next = skip_spaces(next); > @@ -346,8 +347,6 @@ static ssize_t event_trigger_regex_write(struct file > *file, > if (IS_ERR(buf)) > return PTR_ERR(buf); > > - strim(buf); > - > guard(mutex)(&event_mutex); > > event_file = event_file_file(file); > -- > 2.51.0 > > -- Masami Hiramatsu (Google) <[email protected]>
