Re: [PATCH v7] function_graph: Enable funcgraph-args and funcgraph-retaddr to work simultaneously

[Steven Rostedt]

On Fri, 14 Nov 2025 10:55:22 +0800
Donglin Peng <dolinux.p...@gmail.com> wrote:

> --- a/kernel/trace/trace_entries.h
> +++ b/kernel/trace/trace_entries.h
> @@ -95,14 +95,14 @@ FTRACE_ENTRY_PACKED(fgraph_retaddr_entry, 
> fgraph_retaddr_ent_entry,
>       TRACE_GRAPH_RETADDR_ENT,
>  
>       F_STRUCT(
> -             __field_struct( struct fgraph_retaddr_ent,      graph_ent       
> )
> +             __field_struct( struct ftrace_graph_ent,        graph_ent       
> )
>               __field_packed( unsigned long,  graph_ent,      func            
> )
>               __field_packed( unsigned int,   graph_ent,      depth           
> )
> -             __field_packed( unsigned long,  graph_ent,      retaddr         
> )

You can't delete the retaddr without breaking user space.

Please keep that here.

Thanks,

-- Steve

> +             __dynamic_array(unsigned long,  args                            
> )
>       ),
>  
>       F_printk("--> %ps (%u) <- %ps", (void *)__entry->func, __entry->depth,
> -             (void *)__entry->retaddr)
> +             (void *)__entry->args[0])
>  );
>