Hi Song,
Thanks for the review.
> I don't get why we add this selftest here. It doesn't appear to be related to
> patch 1/2.
The regression that patch 1/2 fixes was originally hit by an LSM program
calling bpf_d_path() from the bprm_check_security hook. The new subtest is a
minimal reproducer for that scenario: without patch 1/2 the string comparison
never matches due to verifier's faulty optimization, and with patch 1/2 it
behaves correctly.
> The paragraph above is not really necessary. Just curious, did some AI
> write it?
The paragraph was indeed generated with the help of an AI assistant, and I
didn’t
trim it down enough. I’ll drop it and keep the changelog focused and brief in
v4.
> This {} block is not necessary.
I’ll remove that extra block in v4.
Thanks again for the feedback.
Best regards,
Shuran Liu
