Re: [PATCH 2/2] mm: vmscan: add PIDs to vmscan tracepoints

[Steven Rostedt]

On Mon,  8 Dec 2025 10:14:13 -0800
Thomas Ballasi <tball...@linux.microsoft.com> wrote:

> ---
>  include/trace/events/vmscan.h | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
> index afc9f80d03f34..eddb4e75e2e23 100644
> --- a/include/trace/events/vmscan.h
> +++ b/include/trace/events/vmscan.h
> @@ -121,18 +121,21 @@ 
> DECLARE_EVENT_CLASS(mm_vmscan_direct_reclaim_begin_template,
>       TP_STRUCT__entry(
>               __field(        int,    order           )
>               __field(        unsigned long,  gfp_flags       )
> +             __field(        int,    pid             )

This puts a hole in the ring buffer on 64 bit machines. Please keep pid
next to order as they are both 'int' and not have an "unsigned long"
between the two.

>               __field(        unsigned short, memcg_id        )
>       ),

-- Steve