On 12/18/25 06:40, Garg, Shivank wrote:
On 12/16/2025 9:08 PM, Zi Yan wrote:
On 16 Dec 2025, at 6:11, Shivank Garg wrote:
int collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr,
bool install_pmd)
{
And here.
Since this function is declared in khugepaged.h, I need to
move the enum definition to that header. I see two options for handling
the CONFIG_TRANSPARENT_HUGEPAGE check:
1. Define enum OUTSIDE the ifdef: This allows the static inline stub
to also return enum scan_result, keeping the API consistent.
2. Define enum INSIDE the ifdef: The enum is hidden when THP is disabled,
forcing the stub to return int 0 instead.
The only external caller (uprobes.c) of collapse_pte_mapped_thp currently
ignores the return value.
Probably best to not expose that enum (especially when nobody cares ...)
and instead expose a new void function for uprobe purposes.
Maybe
void collapse_pte_mapped_thp(...)
{
try_collapse_pte_mapped_thp();
}
Maybe something like that?
--
Cheers
David
