On Mon, Jan 05, 2026 at 08:04:22AM -0800, Thomas Ballasi wrote: > Memory reclaim events are currently difficult to attribute to > specific cgroups, making debugging memory pressure issues > challenging. This patch adds memory cgroup ID (memcg_id) to key > vmscan tracepoints to enable better correlation and analysis. > > For operations not associated with a specific cgroup, the field > is defaulted to 0. > > Signed-off-by: Thomas Ballasi <[email protected]>
Couple of comments: 1. memcg_id is u64 but the patch is using 'unsigned short'. 2. I would prefer memcg pointer be passed in tracepoint and then in trace header file cgroup_id() be used similar to other users in include/trace/events/ folder. Orthogonally I am cleaning up memcg id usage and after that cleanup, mem_cgroup_id() would be preferred way to get the ID. No need to do anything now as I will cleanup this usage later as well.
