On Fri, 2026-01-16 at 20:20 +0530, K Prateek Nayak wrote:
> Hello Gabriele, Nam,
>
> On 1/16/2026 6:09 PM, Gabriele Monaco wrote:
> > @@ -2087,6 +2087,8 @@ unsigned long get_wchan(struct task_struct *p)
> >
> > void enqueue_task(struct rq *rq, struct task_struct *p, int flags)
> > {
>
> For delayed task, I think you'll need:
>
> if (trace_sched_enqueue_tp_enabled() && !(flags & ENQUEUE_DELAYED))
>
> > + trace_sched_enqueue_tp(p, rq->cpu);
> > +
> > if (!(flags & ENQUEUE_NOCLOCK))
> > update_rq_clock(rq);
>
> Since delayed tasks haven't hit __block_task(), they are essentially
> still enqueued. Peter should be able to confirm. Other than that,
> the placements of the tracepoints look good now. Feel free to include:
>
> Reviewed-by: K Prateek Nayak <[email protected]>
Mmh, I was sure I missed something after the comments on Nam's patch, thanks for
the heads up and review!
Going to try your suggestion.
Thanks,
Gabriele
