Gabriele Monaco <[email protected]> writes: > On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote: >> The Container class extends RVGenerator but was missing implementations >> for several abstract methods decorated with @not_implemented in the base >> class. This could lead to NotImplementedError exceptions if code paths >> attempt to call these methods on Container instances. >> >> Add empty-string returning stub implementations for >> fill_tracepoint_handlers_skel, >> fill_tracepoint_attach_probe, fill_tracepoint_detach_helper, and >> fill_monitor_class_type. These empty returns are semantically correct >> since Container is a grouping mechanism for organizing monitors, not an >> actual monitor that generates tracepoint-specific C code. >> >> Signed-off-by: Wander Lairson Costa <[email protected]> >> --- > > Just like the previous patch, the NotImplementedError here highlights a > weakness > in the design we should improve instead of cover. > If all those fillers don't make sense for containers, we should instead move > them to Monitor and leave RVGenerator alone.
Agree. Nam
