On Mon, 26 Jan 2026 10:43:54 +0000
Vincent Donnefort <[email protected]> wrote:
> + if (!trace_create_file("tracing_on", TRACEFS_MODE_WRITE, remote_d,
> remote,
> + &tracing_on_fops) ||
> + !trace_create_file("buffer_size_kb", TRACEFS_MODE_WRITE, remote_d,
> remote,
> + &buffer_size_kb_fops) ||
> + !trace_create_file("trace_pipe", TRACEFS_MODE_READ, remote_d,
> remote,
> + &trace_pipe_fops))
> + goto err;
> +
Oh, and don't do this in an if statement. Make them each individually as:
ret = trace_create_file(...);
if (!ret)
goto err;
Linus hates complex if statements and I can see him having a conniption if
he were to see this.
-- Steve
