On Thu, Feb 26, 2026 at 06:26:22PM +0000, Dmitry Ilvokhin wrote: > Add tracepoint instrumentation to zone lock acquire/release operations > via the previously introduced wrappers. > > The implementation follows the mmap_lock tracepoint pattern: a > lightweight inline helper checks whether the tracepoint is enabled and > calls into an out-of-line helper when tracing is active. When > CONFIG_TRACING is disabled, helpers compile to empty inline stubs. > > The fast path is unaffected when tracing is disabled. > > Signed-off-by: Dmitry Ilvokhin <[email protected]>
One nit below other than that: Acked-by: Shakeel Butt <[email protected]> [...] > --- /dev/null > +++ b/mm/zone_lock.c > @@ -0,0 +1,31 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#define CREATE_TRACE_POINTS > +#include <trace/events/zone_lock.h> > + > +#include <linux/zone_lock.h> > + > +EXPORT_TRACEPOINT_SYMBOL(zone_lock_start_locking); > +EXPORT_TRACEPOINT_SYMBOL(zone_lock_acquire_returned); > +EXPORT_TRACEPOINT_SYMBOL(zone_lock_released); > + > +#ifdef CONFIG_TRACING > + > +void __zone_lock_do_trace_start_locking(struct zone *zone) > +{ > + trace_zone_lock_start_locking(zone); > +} > +EXPORT_SYMBOL(__zone_lock_do_trace_start_locking); No reason to not have these as EXPORT_SYMBOL_GPL (& below) > + > +void __zone_lock_do_trace_acquire_returned(struct zone *zone, bool success) > +{ > + trace_zone_lock_acquire_returned(zone, success); > +} > +EXPORT_SYMBOL(__zone_lock_do_trace_acquire_returned); > + > +void __zone_lock_do_trace_released(struct zone *zone) > +{ > + trace_zone_lock_released(zone); > +} > +EXPORT_SYMBOL(__zone_lock_do_trace_released); > + > +#endif /* CONFIG_TRACING */ > -- > 2.47.3 >
