On Thu, Mar 19, 2026 at 05:52:49PM -0400, Steven Rostedt wrote: > On Wed, 18 Mar 2026 21:53:00 -0400 > Aaron Tomlin <[email protected]> wrote: > > > + TP_fast_assign( > > + __entry->dev = disk_devt(q->disk); > > + __entry->hctx_id = hctx->queue_num; > > + __entry->is_sched_tag = is_sched_tag; > > + > > + if (__entry->is_sched_tag) > > Nit, but why use __entry->is_sched_tag instead of is_sched_tag. > > Not sure if the compiler will optimize it (likely it will), but it seems > cleaner to use the variable directly and not the one assigned. > > Perhaps the compiler is smart enough to use one register for both updates. > Hi Steve,
Thank you for your feedback. That was an oversight - I'll correct it now. Kind regards, -- Aaron Tomlin
signature.asc
Description: PGP signature
