On Thu, 26 Mar 2026 20:18:24 +0000 [email protected] wrote: > From: David Laight <[email protected]> > > Change 2d8b7f9bf8e6e ("tracing: Have show_event_trigger/filter format a bit > more in columns") > added space padding to align the output. > However it used ("%*.s", len, "") which requests the default precision. > It doesn't matter here whether the userspace default (0) or kernel > default (no precision) is used, but the format should be "%*s". >
Looks good to me. Acked-by: Masami Hiramatsu (Google) <[email protected]> Thanks! > Signed-off-by: David Laight <[email protected]> > --- > kernel/trace/trace_events.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 249d1cba72c0..6b54c10f9ba4 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -1718,7 +1718,7 @@ static int t_show_filters(struct seq_file *m, void *v) > > len = get_call_len(call); > > - seq_printf(m, "%s:%s%*.s%s\n", call->class->system, > + seq_printf(m, "%s:%s%*s%s\n", call->class->system, > trace_event_name(call), len, "", filter->filter_string); > > return 0; > @@ -1750,7 +1750,7 @@ static int t_show_triggers(struct seq_file *m, void *v) > len = get_call_len(call); > > list_for_each_entry_rcu(data, &file->triggers, list) { > - seq_printf(m, "%s:%s%*.s", call->class->system, > + seq_printf(m, "%s:%s%*s", call->class->system, > trace_event_name(call), len, ""); > > data->cmd_ops->print(m, data); > -- > 2.39.5 > -- Masami Hiramatsu (Google) <[email protected]>
