Hi Theodore, ---- On Mon, 13 Apr 2026 21:12:44 +0800 Theodore Tso <[email protected]> wrote --- > On Mon, Apr 13, 2026 at 09:01:28PM +0800, Li Chen wrote: > > Absolutely! It's great to learn about the Sashiko development site. > > I will address the real issues in the next version. > > Note that Sashiko will sometimes report a pre-existing issue as if it > were a problem with the commit. If that happens, feel free to ignore > its complaint; what I consider best practice is to either (a) fix it > in the a subsequent patch or patch series, or (b) leave a TODO in the > code. > > I've asked the Sashiko folks to add way for URI's for each issue that > are identified by Sashiko, so we can put a URL in the TODO comment for > someone who wants to fix it later, and to make it easier for Sashiko > to identified pre-existing issues so it doesn't comment on the same > issue across multiple commit reviews (and perhaps save on the some LLM > token budget :-). > > In the next few days, for patches sent to linux-ext4, Sashiko will > start e-mailing its reviews to the patch submitter and to me as the > maintainer. Once we can reduce the false positive rate, I'll ask that > the reviews be cc'ed to the linux-ext4 mailing list. But it seems > good enough that to send e-mails to the patch submitter and the > maintainer --- but that's a decision that each subsystem maintainer > will be making on their own.
Got it, thanks. I'll treat Sashiko as a review aid, fix the real issues in the next version, and leave unrelated pre-existing issues for follow-up or a TODO. Regards, Li
