Hi Steven, kernel test robot noticed the following build errors:
[auto build test ERROR on trace/for-next] [also build test ERROR on linus/master v7.1-rc4 next-20260518] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/tracing-probes-Allow-use-of-BTF-names-to-dereference-pointers/20260519-121930 base: https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next patch link: https://lore.kernel.org/r/20260518232312.0c78f055%40gandalf.local.home patch subject: [PATCH v4] tracing/probes: Allow use of BTF names to dereference pointers config: sh-defconfig (https://download.01.org/0day-ci/archive/20260519/[email protected]/config) compiler: sh4-linux-gcc (GCC) 15.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260519/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All errors (new ones prefixed by >>): kernel/trace/trace_probe.c: In function 'parse_probe_arg': >> kernel/trace/trace_probe.c:1289:23: error: implicit declaration of function >> 'query_btf_struct' [-Wimplicit-function-declaration] 1289 | ret = query_btf_struct(arg + 1, ctx); | ^~~~~~~~~~~~~~~~ vim +/query_btf_struct +1289 kernel/trace/trace_probe.c 1120 1121 /* Recursive argument parser */ 1122 static int 1123 parse_probe_arg(char *arg, const struct fetch_type *type, 1124 struct fetch_insn **pcode, struct fetch_insn *end, 1125 struct traceprobe_parse_context *ctx) 1126 { 1127 struct fetch_insn *code = *pcode; 1128 unsigned long param; 1129 int deref = FETCH_OP_DEREF; 1130 long offset = 0; 1131 char *tmp; 1132 int ret = 0; 1133 1134 switch (arg[0]) { 1135 case '$': 1136 ret = parse_probe_vars(arg, type, pcode, end, ctx); 1137 break; 1138 1139 case '%': /* named register */ 1140 if (ctx->flags & (TPARG_FL_TEVENT | TPARG_FL_FPROBE)) { 1141 /* eprobe and fprobe do not handle registers */ 1142 trace_probe_log_err(ctx->offset, BAD_VAR); 1143 break; 1144 } 1145 ret = regs_query_register_offset(arg + 1); 1146 if (ret >= 0) { 1147 code->op = FETCH_OP_REG; 1148 code->param = (unsigned int)ret; 1149 ret = 0; 1150 } else 1151 trace_probe_log_err(ctx->offset, BAD_REG_NAME); 1152 break; 1153 1154 case '@': /* memory, file-offset or symbol */ 1155 if (isdigit(arg[1])) { 1156 ret = kstrtoul(arg + 1, 0, ¶m); 1157 if (ret) { 1158 trace_probe_log_err(ctx->offset, BAD_MEM_ADDR); 1159 break; 1160 } 1161 /* load address */ 1162 code->op = FETCH_OP_IMM; 1163 code->immediate = param; 1164 } else if (arg[1] == '+') { 1165 /* kprobes don't support file offsets */ 1166 if (ctx->flags & TPARG_FL_KERNEL) { 1167 trace_probe_log_err(ctx->offset, FILE_ON_KPROBE); 1168 return -EINVAL; 1169 } 1170 ret = kstrtol(arg + 2, 0, &offset); 1171 if (ret) { 1172 trace_probe_log_err(ctx->offset, BAD_FILE_OFFS); 1173 break; 1174 } 1175 1176 code->op = FETCH_OP_FOFFS; 1177 code->immediate = (unsigned long)offset; // imm64? 1178 } else { 1179 /* uprobes don't support symbols */ 1180 if (!(ctx->flags & TPARG_FL_KERNEL)) { 1181 trace_probe_log_err(ctx->offset, SYM_ON_UPROBE); 1182 return -EINVAL; 1183 } 1184 /* Preserve symbol for updating */ 1185 code->op = FETCH_NOP_SYMBOL; 1186 code->data = kstrdup(arg + 1, GFP_KERNEL); 1187 if (!code->data) 1188 return -ENOMEM; 1189 if (++code == end) { 1190 trace_probe_log_err(ctx->offset, TOO_MANY_OPS); 1191 return -EINVAL; 1192 } 1193 code->op = FETCH_OP_IMM; 1194 code->immediate = 0; 1195 } 1196 /* These are fetching from memory */ 1197 if (++code == end) { 1198 trace_probe_log_err(ctx->offset, TOO_MANY_OPS); 1199 return -EINVAL; 1200 } 1201 *pcode = code; 1202 code->op = FETCH_OP_DEREF; 1203 code->offset = offset; 1204 break; 1205 1206 case '+': /* deref memory */ 1207 case '-': 1208 if (arg[1] == 'u') { 1209 deref = FETCH_OP_UDEREF; 1210 arg[1] = arg[0]; 1211 arg++; 1212 } 1213 if (arg[0] == '+') 1214 arg++; /* Skip '+', because kstrtol() rejects it. */ 1215 tmp = strchr(arg, '('); 1216 if (!tmp) { 1217 trace_probe_log_err(ctx->offset, DEREF_NEED_BRACE); 1218 return -EINVAL; 1219 } 1220 *tmp = '\0'; 1221 ret = kstrtol(arg, 0, &offset); 1222 if (ret) { 1223 trace_probe_log_err(ctx->offset, BAD_DEREF_OFFS); 1224 break; 1225 } 1226 ctx->offset += (tmp + 1 - arg) + (arg[0] != '-' ? 1 : 0); 1227 arg = tmp + 1; 1228 tmp = strrchr(arg, ')'); 1229 if (!tmp) { 1230 trace_probe_log_err(ctx->offset + strlen(arg), 1231 DEREF_OPEN_BRACE); 1232 return -EINVAL; 1233 } else { 1234 const struct fetch_type *t2 = find_fetch_type(NULL, ctx->flags); 1235 int cur_offs = ctx->offset; 1236 1237 *tmp = '\0'; 1238 ret = parse_probe_arg(arg, t2, &code, end, ctx); 1239 if (ret) 1240 break; 1241 ctx->offset = cur_offs; 1242 if (code->op == FETCH_OP_COMM || 1243 code->op == FETCH_OP_DATA) { 1244 trace_probe_log_err(ctx->offset, COMM_CANT_DEREF); 1245 return -EINVAL; 1246 } 1247 if (++code == end) { 1248 trace_probe_log_err(ctx->offset, TOO_MANY_OPS); 1249 return -EINVAL; 1250 } 1251 *pcode = code; 1252 1253 code->op = deref; 1254 code->offset = offset; 1255 /* Reset the last type if used */ 1256 ctx->last_type = NULL; 1257 } 1258 break; 1259 case '\\': /* Immediate value */ 1260 if (arg[1] == '"') { /* Immediate string */ 1261 ret = __parse_imm_string(arg + 2, &tmp, ctx->offset + 2); 1262 if (ret) 1263 break; 1264 code->op = FETCH_OP_DATA; 1265 code->data = tmp; 1266 } else { 1267 ret = str_to_immediate(arg + 1, &code->immediate); 1268 if (ret) 1269 trace_probe_log_err(ctx->offset + 1, BAD_IMM); 1270 else 1271 code->op = FETCH_OP_IMM; 1272 } 1273 break; 1274 case '(': 1275 tmp = strrchr(arg, ')'); 1276 if (!tmp) { 1277 trace_probe_log_err(ctx->offset + strlen(arg), 1278 DEREF_OPEN_BRACE); 1279 return -EINVAL; 1280 } 1281 1282 tmp--; 1283 if (*tmp != '*') { 1284 trace_probe_log_err(ctx->offset + (tmp - arg), 1285 NO_PTR_STRCT); 1286 return -EINVAL; 1287 } 1288 *tmp = '\0'; > 1289 ret = query_btf_struct(arg + 1, ctx); 1290 *tmp = '*'; 1291 1292 if (ret < 0) { 1293 trace_probe_log_err(ctx->offset + 1, NO_PTR_STRCT); 1294 return -EINVAL; 1295 } 1296 1297 ctx->flags |= TPARG_FL_STRUCT; 1298 tmp += 2; 1299 1300 if (*tmp != '$') { 1301 trace_probe_log_err(ctx->offset + (tmp - arg), 1302 BAD_VAR); 1303 return -EINVAL; 1304 } 1305 1306 ctx->offset += tmp - arg; 1307 ret = parse_probe_vars(tmp, type, pcode, end, ctx); 1308 ctx->flags &= ~TPARG_FL_STRUCT; 1309 ctx->last_struct = NULL; 1310 break; 1311 default: 1312 if (isalpha(arg[0]) || arg[0] == '_') { /* BTF variable */ 1313 if (!tparg_is_function_entry(ctx->flags) && 1314 !tparg_is_function_return(ctx->flags)) { 1315 trace_probe_log_err(ctx->offset, NOSUP_BTFARG); 1316 return -EINVAL; 1317 } 1318 ret = parse_btf_arg(arg, pcode, end, ctx); 1319 break; 1320 } 1321 } 1322 if (!ret && code->op == FETCH_OP_NOP) { 1323 /* Parsed, but do not find fetch method */ 1324 trace_probe_log_err(ctx->offset, BAD_FETCH_ARG); 1325 ret = -EINVAL; 1326 } 1327 return ret; 1328 } 1329 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
