On Wednesday, May 20, 2026 9:03 PM Thierry Reding wrote: > On Tue, May 19, 2026 at 02:10:59PM -0400, Steven Rostedt wrote: > > On Tue, 19 May 2026 12:16:43 +0200 > > Artur Kowalski <[email protected]> wrote: > > > > > Use __assign_str and __get_str as required by tracing subsystem. Fixes > > > string fields being rejected by the verifier and unreadable from > > > userspace. > > > > Does anyone use these tracepoints? The fact that they have been broken > > for 5 years and nobody noticed makes me think they are useless. > > > > I rather remove them than fix them, but if someone thinks that these > > are still useful then by all means apply this patch. > > > > Acked-by: Steven Rostedt <[email protected]> > > I know that Mikko used them a lot early on, but this driver is pretty > mature now, so we rarely need this low level of tracing. I'll defer to > Mikko on whether we still need these. > > Thierry
Yeah, these have been quite useful in the past when debugging why a job is failing. Without the cdma traces it can be cumbersome to find out exactly what is being sent to the hardware in some cases. My preference is for keeping them for now. Mikko
