>> @@ -2800,8 +2800,7 @@ static int user_seq_show(struct seq_file *m, void *p) >> >> mutex_unlock(&group->reg_mutex); >> >> - seq_puts(m, "\n"); >> - seq_printf(m, "Active: %d\n", active); >> + seq_printf(m, "\nActive: %d\n", active); >> seq_printf(m, "Busy: %d\n", busy); > > This isn't a critical section and I find the original way easier to read.
Would you prefer to use a seq_putc() call instead at such a source code place? https://elixir.bootlin.com/linux/v7.1-rc7/source/kernel/trace/trace_events_user.c#L2803 > But the other two patches are fine. Thanks for another bit of positive feedback. Regards, Markus
