Hi, On Tue Apr 28, 2026 at 10:30 AM CEST, Markus Schneider-Pargmann (The Capable Hub) wrote: > fp pointer and unsigned long have the same size on all relevant > architectures that build Linux. Furthermore this struct is only used in > architectures that do not set ARCH_DEFINE_ENCODE_FPROBE_HEADER which is > set only for 64bit architectures (apart from LoongArch). > > Both fields are aligned on these architectures so the struct with > __packed and without it are the same. > > Remove the __packed as it is unnecessary.
Friendly ping on this.
Best
Markus
>
> Fixes: 4346ba160409 ("fprobe: Rewrite fprobe on function-graph tracer")
> Signed-off-by: Markus Schneider-Pargmann (The Capable Hub) <[email protected]>
> ---
> kernel/trace/fprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/fprobe.c b/kernel/trace/fprobe.c
> index cc49ebd2a773..21751dcdb7b9 100644
> --- a/kernel/trace/fprobe.c
> +++ b/kernel/trace/fprobe.c
> @@ -181,7 +181,7 @@ static inline void read_fprobe_header(unsigned long
> *stack,
> struct __fprobe_header {
> struct fprobe *fp;
> unsigned long size_words;
> -} __packed;
> +};
>
> #define FPROBE_HEADER_SIZE_IN_LONG SIZE_IN_LONG(sizeof(struct
> __fprobe_header))
>
>
> ---
> base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
> change-id: 20260427-topic-fprobe-packed-v7-1-f44f9bbdedf6
>
> Best regards,
> --
> Markus Schneider-Pargmann (The Capable Hub) <[email protected]>
signature.asc
Description: PGP signature
