On Thu, 11 Jun 2026 10:35:11 -0700 "Alexei Starovoitov" <[email protected]> wrote:
> AI finds things to consider, but when they're considered and postponned > to future it doesn't understand that and keep reporting the same thing > every revision. So it might look like that patches are landing with > outstanding AI complains, but this is not the case. Well, if someone just asked me to give an ack then I would have. But I have other things to work on. Especially since everything I do at the moment is 100% hobby related. The chores my wife gives me now have priority ;-) I'll start a new job come Monday. > > btw since patches touch ftrace from time to time should we add your > ftrace testsuite to bpf CI ? That's actually a good idea. > How automated is it? Very. In fact it's public. Although it's been a few years since I updated the git repos. I have two qemu images (currently private, but I can update them and share). Where one is a 32bit x86 image and the other is a 64bit image. The 64bit image hostname is called tracetest and the 32bit image's hostname is tracetest-32. Both with root password of test0000. The tests loaded on the image is here: https://github.com/rostedt/ftrace-tests And the ktests I run are here: https://github.com/rostedt/ftrace-ktests I would run the ktest like; ktest.pl -DPATCH_CHECKOUT:=<SHA/BRANCH> -DPATCH_START:=<first-commit> tracetest-64.conf And in another window ktest.pl -DPATCH_CHECKOUT:=<SHA/BRANCH> -DPATCH_START:=<first-commit> tracetest-32.conf For example: ktest.pl -DPATCH_CHECKOUT:=trace/ftrace/core -DPATCH_START:=b5d6d3f73d0bac4a7e3a061372f6da166fc6ee5c tracetest-64.conf And that will run 40 tests (I added some more since my last push, so github doesn't have 40) and build, boot, install, test on the qemu 64bit image. It starts out testing commits from b5d6d3f73d0bac4a7e3a061372f6da166fc6ee5c and going through to trace/ftrace/core. Note, the PATCH_START needs to be in the history of the PATCH_CHECKOUT otherwise the test will fail. If you want to run these, let me know and I can help with the setup. It's what I gave Masami to test as well. > > > > >> > >> While at it, please review Mykyta's set: > >> https://patchwork.kernel.org/user/todo/netdevbpf/?series=1096695 > >> > >> It's also been pending for almost a month now. > > > > Have a better link? I just get a blank page as "TODO" is set to what I > > have. > > Ohh. I meant this set: > https://lore.kernel.org/bpf/caef4bzzfjsev3alktwdczf6exocl+eefx+6xa3xgrhbmfo1...@mail.gmail.com/ > where you said that you'll think more about it after pto. I came back on Tuesday and have yet to catch up on all the email I ignored while away :-p > Would be great to land it now for this merge window, so we have > discoverability right now and if better approach comes in the future > we can adjust to it later. > I'll take a look at it. -- Steve
