Hi, On Thu, Jun 18, 2026 at 01:00:58PM +0200, Ahmad Fatoum wrote: > Hello Heikki, > > On 6/18/26 12:56 PM, Heikki Krogerus wrote: > > On Wed, Jun 17, 2026 at 10:03:04PM +0200, Ahmad Fatoum wrote: > >> --- a/drivers/usb/typec/class.c > >> +++ b/drivers/usb/typec/class.c > >> @@ -20,6 +20,9 @@ > >> #include "class.h" > >> #include "pd.h" > >> > >> +#define CREATE_TRACE_POINTS > >> +#include <trace/events/typec.h> > > > > Those should probable go to drivers/usb/typec/trace.c and then you > > need add something like this to drivers/usb/typec/Makefile: > > > > obj-$(CONFIG_TYPEC) += typec.o > > typec-y := class.o mux.o bus.o pd.o > > retimer.o mode_selection.o > > typec-$(CONFIG_ACPI) += port-mapper.o > > +typec-$(CONFIG_TRACING) += trace.o > > Thanks for the suggestion. I will do that for v2. > > I also saw there is Sashiko AI feedback on this patch[1], but I am not > familiar enough with how the event headers are used outside the kernel > to determine if that's actionable advice or if it can be ignored. > > Do you have an opinion on that? > > [1]: > https://sashiko.dev/#/patchset/20260617-typec_set_mode-tracepoint-v1-1-bdfbb39cfccd%40pengutronix.de
It's correct. You need to use a private trace.h in this case, so just move it here: drivers/usb/typec/trace.h And also make sure you include everything needed in that header like it's telling you. Thanks, -- heikki
