Fuad Tabba <[email protected]> writes: > > [...snip...] > >> diff --git a/Documentation/virt/kvm/x86/amd-memory-encryption.rst >> b/Documentation/virt/kvm/x86/amd-memory-encryption.rst >> index bd04a908a8dbd..29409297f1ef0 100644 >> --- a/Documentation/virt/kvm/x86/amd-memory-encryption.rst >> +++ b/Documentation/virt/kvm/x86/amd-memory-encryption.rst >> @@ -503,7 +503,8 @@ secrets. >> >> It is required that the GPA ranges initialized by this command have had the >> KVM_MEMORY_ATTRIBUTE_PRIVATE attribute set in advance. See the documentation >> -for KVM_SET_MEMORY_ATTRIBUTES for more details on this aspect. >> +for KVM_SET_MEMORY_ATTRIBUTES/KVM_SET_MEMORY_ATTRIBUTES2 for more details on >> +this aspect. >> >> Upon success, this command is not guaranteed to have processed the entire >> range requested. Instead, the ``gfn_start``, ``uaddr``, and ``len`` fields >> of >> @@ -511,9 +512,13 @@ range requested. Instead, the ``gfn_start``, ``uaddr``, >> and ``len`` fields of >> remaining range that has yet to be processed. The caller should continue >> calling this command until those fields indicate the entire range has been >> processed, e.g. ``len`` is 0, ``gfn_start`` is equal to the last GFN in the >> -range plus 1, and ``uaddr`` is the last byte of the userspace-provided >> source >> -buffer address plus 1. In the case where ``type`` is >> KVM_SEV_SNP_PAGE_TYPE_ZERO, >> -``uaddr`` will be ignored completely. >> +range plus 1, and ``uaddr`` (if specified) is the last byte of the >> +userspace-provided source buffer address plus 1. >> + >> +In the case where ``type`` is KVM_SEV_SNP_PAGE_TYPE_ZERO, ``uaddr`` will be >> +ignored completely. For all other page types, ``uaddr`` is optional if >> in-place >> +conversion is enable, i.e. when the destination can also be the source, and >> is > > Typo: "is enable" -> "is enabled". > > "when the destination can also be the source" is hard to parse without > context. Maybe: "i.e. when the data has been written directly to > guest_memfd while the range was in the shared state". > > Also, how does userspace discover whether in-place conversion is > enabled? A cross-reference to KVM_CAP_GUEST_MEMFD_MEMORY_ATTRIBUTES > would help here. >
Will fix in the next revision. Thanks! > Cheers, > /fuad > >> >> [...snip...] >>
