On 7/6/26 1:08 PM, Praveen Talari wrote: > The GENI SPI driver reports various transfer failures such as command > timeouts, DMA reset timeouts, DMA transaction errors, and unexpected > interrupt conditions. However, diagnosing the root cause of these > failures is difficult as the hardware state is not captured when the > error occurs. > > Add trace_geni_se_regs() calls at critical SPI error handling paths to > automatically capture GENI serial engine debug registers when failures > are detected. This includes: > > - M_CMD abort/cancel timeout > - DMA TX/RX FSM reset timeout > - DMA transaction failures and pending residue conditions > - Unexpected interrupt error status > - Premature transfer completion with pending TX/RX data > > Dumping the SE debug registers at the time of failure provides > additional hardware context and significantly improves post-mortem > analysis of SPI transfer issues without affecting normal operation. > > Signed-off-by: Praveen Talari <[email protected]> > --- > drivers/spi/spi-geni-qcom.c | 22 ++++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c > index 26e723cfea61..7db0836308c2 100644 > --- a/drivers/spi/spi-geni-qcom.c > +++ b/drivers/spi/spi-geni-qcom.c > @@ -3,6 +3,7 @@ > > #define CREATE_TRACE_POINTS > #include <trace/events/qcom_geni_spi.h> > +#include <trace/events/qcom_geni_se.h>
nit: this could be sorted alphabetically (Mark, could you fix it up while applying?) Reviewed-by: Konrad Dybcio <[email protected]> Konrad
