On 7/30/2026 8:03 AM, Masami Hiramatsu wrote: > On Wed, 29 Jul 2026 14:08:46 -0400 > Steven Rostedt <[email protected]> wrote: > >> >> Masami, >> >> >> On Mon, 27 Jul 2026 12:25:48 +0000 >> Hongyan Xia <[email protected]> wrote: >> >>> From: Hongyan Xia <[email protected]> >>> >>> Static inline should be enough to actually inline functions for most >>> compilers, but my Clang-19 somehow thinks it's better to outline them. >>> These tiny helpers then live in normal .text sections instead of >>> .noinstr sections, violating noinstr. >>> >>> Mark them __always_inline so the compiler can never outline them. >>> >>> Signed-off-by: Hongyan Xia <[email protected]> >>> --- >>> arch/arm64/include/asm/esr.h | 2 +- >>> arch/arm64/include/asm/percpu.h | 2 +- >>> arch/arm64/include/asm/preempt.h | 4 ++-- >>> arch/arm64/include/asm/ptrace.h | 4 ++-- >>> arch/arm64/kernel/debug-monitors.c | 2 +- >>> include/linux/kprobes.h | 8 ++++---- >> >> Are you OK with this patch? If so, can you ack it? > > Yeah, this patch looks good to me. Anyway these are expected to be > inlined. > > Acked-by: Masami Hiramatsu (Google) <[email protected]> > > For other patches, Sashiko noted some comments, I need to check it. > > Thank you,
Right, I just realized this is a badly-ordered series. Patch 9/9 should be merged first regardless, otherwise noinstr in the rest of the series simply won't work because of these outlined functions. > [...]
