On Sun Aug 23, 2026 at 8:17 AM EDT, Mike Rapoport (Microsoft) wrote: > gup_can_follow_protnone() is defined in include/linux/mm.h but only used > by mm/gup.c. > > First, there is no reason to have it in already gigantic header. > > Next, the upcoming refactoring of userfaultfd flags will make > gup_can_follow_protnone() depend on userfaultfd_k.h which would cause a > cyclic header dependency. > > Move gup_can_follow_protnone() to mm/gup.c. > > No functional change. > > Assisted-by: copilot:claude-opus-5 > Signed-off-by: Mike Rapoport (Microsoft) <[email protected]> > --- > include/linux/mm.h | 38 -------------------------------------- > mm/gup.c | 38 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 38 insertions(+), 38 deletions(-) > LGTM.
Reviewed-by: Zi Yan <[email protected]> -- Best Regards, Yan, Zi
