Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The patch fails to implement the missing parenthesis fix claimed in the commit message. - [Low] An unrelated line of documentation was accidentally deleted, breaking a sentence structure. --
commit 708a883b89775bdba5b9179959e1d7aeeadf6600 Author: Manuel Ebner <[email protected]> Documentation: trace: histogram-design: fix bracket, improve wording This commit aims to add a missing parenthesis and include a note about the new way of triggering an event in the histogram-design documentation. > --- > @ Steven, I added this line, because else the references wouldn't make sense. > References: $wakeup_lat, next_pid > > + ... (which > +could equivalently be written trace(wakeup_latency,$wakeup_lat,next_pid) > are implemented, the parameters specified to the trace handler must be > variables. In this case, $wakeup_lat is obviously a variable, but > next_pid isn't, since it's just naming a field in the sched_switch > --- [Severity: Medium] It looks like the intended fix for the missing parenthesis was accidentally placed between the `---` separators in the commit message. As a result, this hunk is treated as commentary by git and dropped during patch application, so the parenthesis fix is missing from the actual file. Should this hunk be moved into the diff proper? > diff --git a/Documentation/trace/histogram-design.rst > b/Documentation/trace/histogram-design.rst > index 41a726cd35369..86c83b177e446 100644 > --- a/Documentation/trace/histogram-design.rst > +++ b/Documentation/trace/histogram-design.rst > @@ -25,7 +25,7 @@ tracing_map.c. > > If the kernel is compiled with CONFIG_HIST_TRIGGERS_DEBUG set, an > event file named 'hist_debug' will appear in each event's > -subdirectory. This file can be read at any time and will display some > + [Severity: Low] Was this deletion intentional? It appears an unrelated line of documentation was accidentally removed here, breaking the sentence structure of the paragraph. > of the hist trigger internals described in this document. Specific > examples and output will be described in test cases below. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
