Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Missing #include <linux/export.h> for EXPORT_SYMBOL macro. --
commit 44baf41b1565a3ea5c2669a320dc9b29217d32c3 Author: Thierry Reding <[email protected]> of: Export of_node_to_nid() This commit exports of_node_to_nid() so that drivers buildable as modules can use it. > diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c > index 230d5f628c1b4..da2e9bd1717c2 100644 > --- a/drivers/of/of_numa.c > +++ b/drivers/of/of_numa.c > @@ -171,6 +171,7 @@ int of_node_to_nid(struct device_node *device) > > return NUMA_NO_NODE; > } > +EXPORT_SYMBOL(of_node_to_nid); [Severity: Low] Should this file explicitly include <linux/export.h> or <linux/module.h>? Using EXPORT_SYMBOL without explicitly including its defining header relies on transitive includes. This could potentially cause build failures if those implicit includes change in the future on certain configurations or architectures. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=6
