On Fri, 11 Sep 2026 01:30:48 +0900
Sang-Heon Jeon <[email protected]> wrote:
> After the loop, node is the last array value that xbc_add_child()
> added, and xbc_parse_array() sets node->child to 0.
>
> xbc_init_node() already set node->child to 0 when the value was
> added, and node->child is not modified after that, so the assignment
> is redundant.
>
> So remove the assignment.
>
> No functional change.
>
Looks good to me. It seems commit ca24306d83a1 ("bootconfig: Change
array value to use child node") has replaced next to child by mistake.
Thank you!
> Signed-off-by: Sang-Heon Jeon <[email protected]>
> ---
> lib/bootconfig.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/bootconfig.c b/lib/bootconfig.c
> index aba11caf6903..12dd259d490e 100644
> --- a/lib/bootconfig.c
> +++ b/lib/bootconfig.c
> @@ -833,7 +833,6 @@ static int __init xbc_parse_array(char **__v)
> return -ENOMEM;
> *__v = next;
> } while (c == ',');
> - node->child = 0;
>
> return c;
> }
>
> base-commit: 13e8b7707efcea3a401d242958ba0a392f227847
> --
> 2.43.0
>
--
Masami Hiramatsu (Google) <[email protected]>
