> Tracepoint consumers use a ruleset ID and version to identify the > successful landlock_add_rule(2) call prefix used to create a domain. > LANDLOCK_MAX_NUM_RULES bounds distinct stored rules, not successful > calls: re-adding already-present rights for an object or port succeeds > without increasing num_rules. Because every successful call increments > the version, these calls can wrap the 32-bit counter and give different > prefixes the same trace identity. > > Widen the counter and its trace fields to 64 bits so the counter cannot > wrap in practice, while preserving the successful-call semantics. > Saturating would alias all subsequent histories, while rejecting a call > at the limit would change otherwise valid syscall behavior solely for > trace metadata. > > Cc: Günther Noack <[email protected]> > Cc: Steven Rostedt <[email protected]> > Fixes: 63747c94774d ("landlock: Add landlock_add_rule_fs and > landlock_add_rule_net tracepoints") > Signed-off-by: Mickaël Salaün <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
