Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] build: missing VMLINUX_BTF_PATHS update in HID BPF Makefile --
commit 2f39c92d5ae7cb936808a6ebbea40b69c54c9b41 Author: Jay Wang <[email protected]> tools, samples: take the vmlinux BTF from vmlinux.unstripped first This commit updates several Makefiles to prioritize vmlinux.unstripped when searching for BTF information. This prevents build failures for bpftool skeletons when the kernel is built with CONFIG_DEBUG_INFO_BTF=m, which strips the .BTF section from vmlinux. > diff --git a/tools/testing/selftests/hid/Makefile > b/tools/testing/selftests/hid/Makefile > index 2f423de831473..8b85382be254b 100644 > --- a/tools/testing/selftests/hid/Makefile > +++ b/tools/testing/selftests/hid/Makefile [ ... ] > @@ -81,8 +81,12 @@ endif > HOST_BPFOBJ := $(HOST_BUILD_DIR)/libbpf/libbpf.a > RESOLVE_BTFIDS := $(HOST_BUILD_DIR)/resolve_btfids/resolve_btfids > > -VMLINUX_BTF_PATHS ?= $(if $(O),$(O)/vmlinux) \ > +# With CONFIG_DEBUG_INFO_BTF=m only vmlinux.unstripped has the BTF > +VMLINUX_BTF_PATHS ?= $(if $(O),$(O)/vmlinux.unstripped) > \ > + $(if $(O),$(O)/vmlinux) \ > + $(if $(KBUILD_OUTPUT),$(KBUILD_OUTPUT)/vmlinux.unstripped) > \ > $(if $(KBUILD_OUTPUT),$(KBUILD_OUTPUT)/vmlinux) \ > + ../../../../vmlinux.unstripped \ > ../../../../vmlinux \ > /sys/kernel/btf/vmlinux \ > /boot/vmlinux-$(shell uname -r) [Severity: Low] Was drivers/hid/bpf/progs/Makefile intentionally omitted from this patch? Looking at drivers/hid/bpf/progs/Makefile, it still searches for the stripped vmlinux and does not include the fallback for vmlinux.unstripped: drivers/hid/bpf/progs/Makefile: VMLINUX_BTF_PATHS ?= $(if $(O),$(O)/vmlinux) \ $(if $(KBUILD_OUTPUT),$(KBUILD_OUTPUT)/vmlinux) \ ../../../../vmlinux \ /sys/kernel/btf/vmlinux \ /boot/vmlinux-$(shell uname -r) Could this cause build regressions for HID BPF programs (which are built when running tools/testing/selftests/hid/vmtest.sh) when the kernel is built with CONFIG_DEBUG_INFO_BTF=m? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=11
