> format_disasm_line() strips trailing newlines from the disassembly it
> stores, as diag_print_insn_context() adds its own. Since
> commit 483a1bb0b6cf8 ("bpf: Do not print a newline after disassembly in
> bpf_verbose_insn()"), print_bpf_insn() does not emit one, so there is
> nothing left to strip.
>
> The strnlen() resync of the seq_buf length only existed so the loop
> could index the buffer safely after an overflow, and the second
> termination only restored the NUL that seq_buf_pop() does not write.
> Remove all of it, keeping a single seq_buf_terminate().
>
> Build tested ARCH=x86_64 defconfig with GCC 16.2.0 and
> CONFIG_BPF_SYSCALL=y.
>
> Assisted-by: LLM
> Signed-off-by: Kees Cook <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review ยท
https://sashiko.dev/#/patchset/[email protected]?part=7
