Building kernel/trace/trace_osnoise.o with W=1 triggers the following compiler warning:
kernel/trace/trace_osnoise.c:96:17: warning: function 'osnoise_print' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] osnoise_print() forwards its format string and va_list arguments to trace_array_vprintk(), which is annotated with __printf(3, 0). Add the __printf(1, 2) attribute to osnoise_print() to silence the W=1 warning and enable compile-time format string checking for its callers. Signed-off-by: Adrián García Casado <[email protected]> --- kernel/trace/trace_osnoise.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index 0e1265acd1..995da9e0b5 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -83,6 +83,7 @@ struct osnoise_instance { static struct list_head osnoise_instances; +__printf(1, 2) static void osnoise_print(const char *fmt, ...) { struct osnoise_instance *inst; -- 2.39.5
