On Mon, Oct 19, 2026 at 11:53 AM Ridong Chen <[email protected]> wrote: > > From: Ridong Chen <[email protected]> > > The definition of struct scan_control has lived inline at the top of > mm/vmscan.c. Move it out to a new mm/vmscan.h so the reclaim-internal > state can be referenced from other reclaim translation units without > duplicating the definition. > > The header uses an ordinary include guard and pulls in only what the > struct needs (nodemask_t, gfp_t and struct reclaim_state). > > mm/trace_vmscan.h includes the new header directly so that any > translation unit pulling in the trace events (mm/vmscan.c, mm/shrinker.c) > sees the full definition of struct scan_control regardless of include > order. > > No functional change. > > Assisted-by: LLM > Signed-off-by: Ridong Chen <[email protected]> > ---
Well, vmscan.c is way too long, so moving some common code out of it seems like a good idea, beyond just serving the needs of tracepoints. We may move more code out of it in the future. Best Regards Barry
