Cool no worries. Makes sense.
Thanks Masami
On Thu, 29 Oct 2026 at 03:08, Masami Hiramatsu (Google)
<[email protected]> wrote:
>
> On Tue, 27 Oct 2026 09:37:20 +0200, Avi Weiss <[email protected]> wrote:
>
> Hi Avi,
>
> Thanks for fixing this! This looks good to me. Let me pick it.
>
> > start_kernel() appends command-line init arguments before
> > bootconfig init arguments, while setup_command_line()
> > places them in the opposite order. As a result, the
> > arguments passed to init do not match the saved command
> > line, reversing the intended precedence of options.
> >
> > Parse extra_init_args before after_dashes so command-line
> > init arguments are passed last.
> >
> > Fixes: 1319916209ce ("bootconfig: init: Allow admin to use bootconfig for
> > init command line")
>
> BTW, the Fixes: tag should point to commit b66fbbe8d482 ("init/bootconfig:
> Reorder init parameter from bootconfig and cmdline").
>
> In commit 1319916209ce, both setup_command_line() and start_kernel() placed
> extra_init_args after command-line args. It was commit b66fbbe8d482 that
> reordered setup_command_line() so that command-line init arguments come
> last (to allow cmdline to override bootconfig), but missed reordering
> start_kernel().
>
> Thus I will change the Fixes tag as below.
>
> Fixes: b66fbbe8d482 ("init/bootconfig: Reorder init parameter from bootconfig
> and cmdline")
>
> > Signed-off-by: Avi Weiss <[email protected]>
> > ---
> > init/main.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
>
> Thanks!
>
> --
> Masami Hiramatsu (Google) <[email protected]>
>
