On Sat, 31 Oct 2026 11:25:30 +0100, Eduardo Mucelli Rezende Oliveira <[email protected]> wrote: > Hi Masami, > > Thanks for the review. I've updated the event-filter patch to use the > explicit delimiter pattern you suggested. It now warns and skips filters > that contain delimiters and both quote types, since bootconfig cannot > represent them. The other three patches are unchanged. > > Changes in v2: > - Patch 1: use explicit escapes in *[,\;\#\}]* for the delimiter check. > The semicolon also needs escaping for the shell to parse the pattern. > - Patch 1: detect both quote types, warn on stderr and skip the filter. > - Patches 2-4: no changes. > > The series keeps event filters, generic trigger counts, histogram > variable ordering and paused histogram state during export. It is still > based on bootconfig/fixes, including the two fixes you picked up earlier. > > I retested the filter change in a temporary tracefs instance on my Ubuntu > machine, running kernel 7.0.0-38-generic, with recording disabled. I also > checked the mixed-quote cases against real tracefs filters and added > regression checks for both quote orders and all four delimiters. The > fixture checks cover each fix and the full series.
Thanks, this series looks good to me. Let me pick those. > > Feedback is welcome. > > Thanks, > Eduardo > > Eduardo Mucelli Rezende Oliveira (4): > tools/bootconfig: Quote event filters in ftrace2bconf.sh > tools/bootconfig: Export replayable event trigger counts > tools/bootconfig: Reset histogram variable tracking for each instance > tools/bootconfig: Preserve paused histograms in ftrace2bconf.sh > > tools/bootconfig/scripts/ftrace2bconf.sh | 29 +++++++++++++++++++++--- > 1 file changed, 26 insertions(+), 3 deletions(-) > > > base-commit: 1dc6d173c43e10a1d0ee36b43d0d2f371f4d262a > -- > 2.53.0 > > -- Masami Hiramatsu (Google) <[email protected]>
