Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] tracefs: mismatched kernel-doc function name for __eventfs_root_lookup() --
commit a184dfa06e9d76ab752cc43b8175907e50ee86f0 Author: Anubhav Shelat <[email protected]> tracefs: Add read-only eventfs filesystem at /sys/kernel/events This commit introduces a read-only eventfs pseudo-filesystem mounted at /sys/kernel/events that exposes trace event format and id files to unprivileged users by reusing the existing eventfs_inode lazy-lookup infrastructure. > diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c > index 6e3513b13cfa2..8875b0241453b 100644 > --- a/fs/tracefs/event_inode.c > +++ b/fs/tracefs/event_inode.c [ ... ] > @@ -521,14 +647,16 @@ lookup_file_dentry(struct dentry *dentry, > * @dir: in which a lookup is being done > * @dentry: file/dir dentry > * @flags: Just passed to simple_lookup() > + * @ro: Denote if this is from a read-only eventfs > * > * Used to create dynamic file/dir with-in @dir, search with-in @ei > * list, if @dentry found go ahead and create the file/dir > */ > > -static struct dentry *eventfs_root_lookup(struct inode *dir, > - struct dentry *dentry, > - unsigned int flags) > +static struct dentry *__eventfs_root_lookup(struct inode *dir, > + struct dentry *dentry, > + unsigned int flags, > + bool ro) [Severity: Low] As reported by Sashiko on v5 [1], this isn't a bug, but since eventfs_root_lookup() in fs/tracefs/event_inode.c was renamed to __eventfs_root_lookup(), should the function name in the kernel-doc comment header above it also be updated to __eventfs_root_lookup to avoid a W=1 kernel-doc prototype mismatch warning? [1] https://lore.kernel.org/r/[email protected] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
