On Thursday, 24. May 2001 08:06, you wrote:
> Thanks for the comments.
My pleasure. I find finding bugs kind of refreshing ;-)
> > 7)
> > in write:
> >
> > you release the lock before the URB is completed.
> > This is deadly.
>
> It is if you want to use it to show completion of the urb. You mentioned
> holding the semaphore until the completion function is called as one way
> to solve the urb->status problem in a different message. I think I'll
> incorporate this, or just add a "urb complete" flag in the structure to
> solve the race condition.
If you want this driver to be educational you should definitely go for a
flag, complete with waitqueue, timeout and signal handling.
I'll be happy to go over the code again.
Regards
Oliver
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
