On Sat, Jun 02, 2001 at 12:04:24AM +0200, Oliver Neukum wrote:
> On Friday, 1. June 2001 19:32, you wrote:
> > On Fri, Jun 01, 2001 at 12:36:43PM +0200, Alessandro Ronchi wrote:
> > > Why don't you put a update version on a website?
> >
> > Doh, how about adding this to the -ac kernel tree, so that others can
> > also work on it if they want to, and I don't forget to post updates :)
> >
> > Alan, could you add this patch to your tree?
>
> 1) Now you are using an async unlink in skel_release, as you can sleep there,
> why ?
> You are causing a race between module unload and unlinking this way. We
> discussed doing this for the version of the serial driver using spinlocks,
> but here IMHO it's wrong.
I agree with you. I hadn't made that change yet, and that's why I
hadn't sent an updated version to the list. But now that it's in the
-ac tree, patches are welcome :)
> 2) In skel_read you don't report a failure in submitting an urb to user space.
Thanks, I will fix that.
To everyone else: If you see something in the usb-skeleton driver that
you feel should be changed, please send patches. The driver is there
for everyone to use.
thanks,
greg k-h
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
