On Friday, 1. June 2001 19:32, you wrote:
> On Fri, Jun 01, 2001 at 12:36:43PM +0200, Alessandro Ronchi wrote:
> > Why don't you put a update version on a website?
>
> Doh, how about adding this to the -ac kernel tree, so that others can
> also work on it if they want to, and I don't forget to post updates :)
>
> Alan, could you add this patch to your tree?
1) Now you are using an async unlink in skel_release, as you can sleep there,
why ?
You are causing a race between module unload and unlinking this way. We
discussed doing this for the version of the serial driver using spinlocks,
but here IMHO it's wrong.
2) In skel_read you don't report a failure in submitting an urb to user space.
Regards
Oliver
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
