On Mon, 3 Dec 2001, Martin Diehl wrote:

> [single-shot int not working with usb-uhci]
> 
> Well - I just want to give you some early indication as this came up here.
> I'm gonna try to get more information.

Gotcha!

During some walkthrough along the interrupt-urb paths of usb-uhci and the
single-shot case in particular I stumbled over a line which I really
doubt is what it is supposed to. Seems there are some parentheses missing
and nobody really used that stuff for some time ;-)

The patch below should fix this issue. At least for me everything is fine
now, i.e. both single-shot and periodic int transfers working with all
three usb-ohci, usb-uhci and uhci(JE).

Martin

-------------------

--- linux-2.4.16/drivers/usb/usb-uhci.c Mon Dec  3 18:51:37 2001
+++ v2.4.16-md/drivers/usb/usb-uhci.c   Mon Dec  3 22:42:55 2001
@@ -2445,7 +2445,7 @@
                        break;
                }
 
-               if (!desc->hw.td.status & cpu_to_le32(TD_CTRL_IOC)) {
+               if (!(desc->hw.td.status & cpu_to_le32(TD_CTRL_IOC))) {
                        // do not process one-shot TDs, no recycling
                        break;
                }


_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to