On Tue, 4 Dec 2001, Mark Burazin wrote:

> Someone joust submitted a patch for the usb-uhci, I tryed it, but still not 
> working, while the uhci is ok.

Ok, the patch was just to address some issue which I've suspected during 
some code inspection (I take Georgs reply to confirm this). It made some
test happy for me and there was another "now working" report here IIRC).
However, it seems this was not the whole thing.

> With usb-uhci i receive -ECONNABORTED while submitting urbs. (currently the 

During submitting? Strange. For me, the usb_submit_usb succeeds (like it
always did without the patch). And the completion handler gets called with
urb->status=0. However, with further testing I'm able now to reproduce
the status gets changed to ECONNABORTED _after_ the completion handler
returned (but already before doing anything else like an additional
unlink). Even width additional 10ms sleep the status never changes from
ECONNABORTED - and I tend to believe the URB never gets completely removed
from the schedule.

However, my understanding of the details of usb-uhci is pretty limited, so
I have to surrender at this point :-(

Martin

PS:

>     if ( usb_submit_urb( outurb ) )
>     {
>         err( DRIVER_NAME ": Failed(%d) submit urb!\n", outurb->status );
>               spin_unlock ( &global_usb_nepp->io_lock );

so you have this spinlock still acquired in the submit-succeed case

>         return -EIO;
>     }
>       interruptible_sleep_on_timeout ( &global_usb_nepp->write_wait, 1500 * 
> HZ/1000 );

... but go sleeping here?
And sleep_on and friends are really deprecated due to races.


_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to