Greg KH wrote: > On Tue, Mar 12, 2002 at 06:39:52PM +0530, V Ganesh wrote: > >>I'm halfway through. this is the approach I'm using, please comment: >>1. all *_callback() functions must use GFP_ATOMIC. >> > > Good. > > >>2. anything inside a spinlock must use GFP_ATOMIC. >> > > No, we should not be calling usb_submit_urb() with a spinlock held. > Which usb-serial driver is doing this? >
Ugh. At least, iforce and hid submit urbs with a spinlock held. How could that be wrong ? usb_submit_urb is not going to execute any part of my code (ie iforce), is it ? So why would it care if I locked one of my own spinlocks or not ? iforce is not a usb-serial driver, though. Did you mean that only usb-serial drivers may not submit urbs while holding a spinlock ? -- Johann Deneux _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
