On Wed, Mar 13, 2002 at 10:01:22AM +0100, Oliver Neukum wrote: > > > > > 2. anything inside a spinlock must use GFP_ATOMIC. > > > > > > No, we should not be calling usb_submit_urb() with a spinlock held. > > > Which usb-serial driver is doing this? > > > > ipaq. mea culpa, I'll fix it. > > also digi_accelport.c where practically all urbs are submitted holding a > > spinlock. > > Why exactly is this bad ?
It isn't bad (now in the 2.5 kernel with the ability to specify the mem_flags to usb_submit_urb()), but I was just curious, as I thought that I had changed all of the usb-serial drivers to not do this in the past. But it is _not_ a good thing to do in the 2.4 kernel right now. thanks, greg k-h _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
