I found the problem.  It's not in usb-storage, but in the usb core.

The patch from David Brownell "USB: usbcore misc cleanup (notably for
non-dma hcds)" seems to be the problem.  If I revert it out of my tree,
everything works again.

This even makes sense -- that patch changes some things in the
scatter-gather primitives, which are exactly the types of transfers which
aren't working properly.

I have a sneaking suspicion that usb-storage may be the only code that uses
the scatter-gather stuff, which is why nothing else showed any problems
from David's patch.

Greg, I would recommend reverting David's patch, and then send it all to
Linus.

Matt

On Sat, Feb 01, 2003 at 03:24:42PM -0800, Matthew Dharm wrote:
> This gets even more strange...
> 
> It looks like transfers that don't use scatter-gather work just fine.
> INQUIRY, MODE_SENSE, etc. all behave normally.
> 
> But, if the transfer is scatter-gather, then somehow the data never makes
> it in, even tho it's transferred over the wire.
> 
> I'm only looking at reads now, but this definately used to work just fine.
> 
> Matt
> 
> On Sat, Feb 01, 2003 at 02:31:56PM -0800, Matthew Dharm wrote:
> > On Wed, Jan 29, 2003 at 03:32:35PM -0800, Greg KH wrote:
> > > On Mon, Jan 27, 2003 at 06:32:11PM -0800, Matthew Dharm wrote:
> > > > (o) the set of patches we're talking about now
> > > 
> > > I've also applied all of these, but still can't read the partition
> > > table.  Ok, I'll leave all of the patches in my tree, but will not send
> > > them on to Linus until things work again for me.  Sound ok?
> > 
> > Okay, something is definately strange...
> > 
> > With OHCI, I get all sorts of errors (babble, etc).  With UHCI, I don't get
> > those errors.
> > 
> > However, when I try to read from my devices, things go weird.  The commands
> > are being executed, and data is moving in, but the data is bad.  It looks
> > like old buffers or something -- but definately not from the USB-device's
> > media.
> > 
> > Greg, have you tried dd'ing some data and looking at it with hexdump?
> > 
> > Matt
> > 
> > -- 
> > Matthew Dharm                              Home: [EMAIL PROTECTED] 
> > Maintainer, Linux USB Mass Storage Driver
> > 
> > Sir, for the hundreth time, we do NOT carry 600-round boxes of belt-fed 
> > suction darts!
> >                                     -- Salesperson to Greg
> > User Friendly, 12/30/1997
> 
> 
> 
> -- 
> Matthew Dharm                              Home: [EMAIL PROTECTED] 
> Maintainer, Linux USB Mass Storage Driver
> 
> E:  You run this ship with Windows?!  YOU IDIOT!
> L:  Give me a break, it came bundled with the computer!
>                                       -- ESR and Lan Solaris
> User Friendly, 12/8/1998



-- 
Matthew Dharm                              Home: [EMAIL PROTECTED] 
Maintainer, Linux USB Mass Storage Driver

C:  They kicked your ass, didn't they?
S:  They were cheating!
                                        -- The Chief and Stef
User Friendly, 11/19/1997

Attachment: msg11197/pgp00000.pgp
Description: PGP signature

Reply via email to