I've been digging into the OHCI driver to understand and/or fix a couple
of bugs I've been running into and I noticed this comment.
It's not accurate anymore since all 3 HCs use urb->timeout as a relative
value.
David, it appears that timeouts aren't even enabled in the OHCI driver
because DO_TIMEOUTS is not defined anywhere. Did I miss where it was
defined or was this done on purpose?
JE
# This is a BitKeeper generated patch for the following project:
# Project Name: greg k-h's linux 2.4 USB kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.810 -> 1.811
# drivers/usb/usb-ohci.c 1.38 -> 1.39
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/02/07 [EMAIL PROTECTED] 1.811
# usb-ohci.c:
# Remove obsolete comment about usage of urb->timeout
# --------------------------------------------
#
diff -Nru a/drivers/usb/usb-ohci.c b/drivers/usb/usb-ohci.c
--- a/drivers/usb/usb-ohci.c Fri Feb 7 13:20:24 2003
+++ b/drivers/usb/usb-ohci.c Fri Feb 7 13:20:25 2003
@@ -695,9 +695,6 @@
if (urb->timeout) {
struct list_head *entry;
- // FIXME: usb-uhci uses relative timeouts (like this),
- // while uhci uses absolute ones (probably better).
- // Pick one solution and change the affected drivers.
urb->timeout += jiffies;
list_for_each (entry, &ohci->timeout_list) {
-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
