Johannes Erdfelt wrote:
I've been digging into the OHCI driver to understand and/or fix a couple
of bugs I've been running into and I noticed this comment.

It's not accurate anymore since all 3 HCs use urb->timeout as a relative
value.
Good to know that ... thanks for the patch(es)!  (Greg, please merge
when you get back.)


David, it appears that timeouts aren't even enabled in the OHCI driver
because DO_TIMEOUTS is not defined anywhere. Did I miss where it was
defined or was this done on purpose?
It's not defined ... the DO_TIMEOUTS code probably doesn't work
either (submitted by accident).

Seems like right now only the UHCI code supports timeouts.  I've
not been able to persuade myself that it really matters ... all
drivers seem to behave OK using higher level timeouts (as in SCSI,
or usb_control_msg).  On the other hand, I've not persuaded myself
to simplify the 2.5 UHCI code by removing that, either ... ;)

- Dave




-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to