On Sat, Feb 22, 2003 at 09:58:52AM +0100, Thomas Jarosch wrote:
> > On Fri, Feb 21, 2003 at 10:04:14PM +0100, Thomas Jarosch wrote:
> > > This is a patch against the ftdi_sio 1.3.0 driver + interim patch.
> > > The new driver should be out soon...
> >
> > Can you post it not compressed so we can read it?
>
> Sure. I compressed it to save bandwith...
Hm, seems to have dropped all tabs, can you try sending it again so that
it could be applied properly?
One small comment on the code:
> +typedef struct {
> + unsigned char enable;
> + unsigned char bitmask; /* description of bitmask: see above */
> +} ftdi_bitbang_t;
> +
> +typedef struct {
> + unsigned char data[128]; /* eeprom size is fixed to 128 bytes by hardware */
> +} ftdi_eeprom_t;
typedef is evil and should NEVER be used in a driver for a structure.
See my many rants on this in the past on lkml, and my OLS 2002
paper[1] and presentation[2], and Linux Journal article[3] for more details.
thanks,
greg k-h
[1] http://www.kroah.com/linux/talks/ols_2002_kernel_codingstyle_paper/codingstyle.ps
[2] http://www.kroah.com/linux/talks/ols_2002_kernel_codingstyle_talk/html/
[3] http://www.linuxjournal.com/article.php?sid=5780
-------------------------------------------------------
This SF.net email is sponsored by: SlickEdit Inc. Develop an edge.
The most comprehensive and flexible code editor you can use.
Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial.
www.slickedit.com/sourceforge
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
