> Hm, seems to have dropped all tabs, can you try sending it again so that
> it could be applied properly?
Hmm, just save the compressed version to disk :-)
> One small comment on the code:
> > +typedef struct {
> > + unsigned char enable;
> > + unsigned char bitmask; /* description of bitmask: see above */
> > +} ftdi_bitbang_t;
> > +
> > +typedef struct {
> > + unsigned char data[128]; /* eeprom size is fixed to 128 bytes by
> > hardware */ +} ftdi_eeprom_t;
>
> typedef is evil and should NEVER be used in a driver for a structure.
> See my many rants on this in the past on lkml, and my OLS 2002
> paper[1] and presentation[2], and Linux Journal article[3] for more
> details.
I'm normally not doing kernel things... I'll have a look at your articles
and change the code.
Thanks,
Thomas
-------------------------------------------------------
This SF.net email is sponsored by: SlickEdit Inc. Develop an edge.
The most comprehensive and flexible code editor you can use.
Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial.
www.slickedit.com/sourceforge
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
