On Fri, Mar 14, 2003 at 03:48:24AM +0100, Oliver Neukum wrote:
Hi Greg,
you recently asked whether the module pointers could be removed. I looked at the question and the answers is that they cannot be removed. The ioctl into the driver through usbfs makes that impossible.
Ah crap, I hate that ioctl!
Only one driver has ever used it, the hub driver.
Actually "usbtest" implements it too. Remove it and there will no longer be any systematic way to test HCDs...
Hm...
Ah, in looking both at the libusb code, and usbutils (lsusb and friends), they do not actually use the USBDEVFS_HUB_PORTINFO ioctl call into usbfs (which calls the hub driver's ioctl call.)
So, any complaints if I get rid of the hub_ioctl() call in hub.c? That way we can drop the ioctl field in the usb_driver structure, and the logic in devio.c to call the ioctl (which is some heavily locking code).
But that way the jUSB code would break completely. I really don't want to have to re-implement that logic at this point, and there are a reasonable number of people using it (and even asking for updates, which I'm scarce on time to provide).
The basic problem is that "usbfs" has never done quite what it's needed to do. It needs a redesign, as I think you've also noted.
Too bad "sysfs" doesn't seem to want to hold general purpose read/write files, or it'd have a number of the most important capabilities: exposing device and interface descriptor state, as well as the logical structure of the USB trees, "live".
And then, it looks like we could drop the struct module * also in the usb_driver, as we are protected by the driver core during the other calls into the usb driver, right? (Unless I ever prove a need for using the module reference count in a urb :)
Anyway, I want to drop that ioctl field, any objections? Anyone actually using this code anywhere?
Yes, see above ... at least two other users.
- Dave
thanks,
greg k-h
-------------------------------------------------------
This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod:
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
-------------------------------------------------------
This SF.net email is sponsored by:Crypto Challenge is now open! Get cracking and register here for some mind boggling fun and the chance of winning an Apple iPod:
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
